Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ECAL DQM Presample and Trigger primitive plots thresholds [13_1_X] #42243

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Change ECAL DQM Presample and Trigger primitive plots thresholds [13_1_X] #42243

merged 1 commit into from
Jul 17, 2023

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Jul 12, 2023 •
edited
Loading

PR description:

This PR changes the thresholds of

  • Presample Quality plot to remove the ring of red spots observed in the Ecal endcaps
  • Trigger Primitive emulator quality plot to remove the red towers at high eta in the endcaps

These are known issues due to ageing and radiation effects and the thresholds will need to be assessed and changed further, if need be.

PR validation:

PR is validated by running the ECAL online DQM configuration and verifying the plots on a test DQM GUI.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport to 13_1_X, which is next in production.
Master PR is #42242.
Another backport to production version 13_0_X: #42244

@cmsbuild cmsbuild added this to the CMSSW_13_1_X milestone Jul 12, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 12, 2023 •
edited
Loading

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_13_1_X.

It involves the following packages:

  • DQM/EcalMonitorClient (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @missirol, @argiro, @thomreis, @wang0jin this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@abhih1 abhih1 changed the title Change ECAL DQM Presample and Trigger primitive plots thresholds 13_1_X Change ECAL DQM Presample and Trigger primitive plots thresholds [13_1_X] Jul 12, 2023
@perrotta
Copy link
Contributor

backport of #42242

@thomreis
Copy link
Contributor

type ecal

@thomreis
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11917f/33676/summary.html
COMMIT: 939d384
CMSSW: CMSSW_13_1_X_2023-07-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42243/33676/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • You potentially removed 13 lines from the logs
  • Reco comparison results: 194 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222791
  • DQMHistoTests: Total failures: 5107
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3217662
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11917f/33698/summary.html
COMMIT: 939d384
CMSSW: CMSSW_13_1_X_2023-07-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42243/33698/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 13 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3192009
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3191973
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 32a1ce3 into cms-sw:CMSSW_13_1_X Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok dqm-approved ecal fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_1_X
Development

Successfully merging this pull request may close these issues.
6 participants
@abhih1 @cmsbuild @perrotta @thomreis @emanueleusai @rappoccio